Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test and code improvements #9

Merged
merged 4 commits into from
Nov 8, 2022
Merged

Test and code improvements #9

merged 4 commits into from
Nov 8, 2022

Conversation

danielfireman
Copy link
Collaborator

  • Many test improvements: besides performing more checks, my goal was to make tests easier to read
  • Improvements in the main code:
    • Propagate user-specific context, even when timing out
    • Make the HTTP client private
    • Use the correct field to set the amount of time to wait between retries
    • Using the file name as the download file name

cuducos
cuducos approved these changes Nov 8, 2022
View reviewed changes
main_test.go Show resolved Hide resolved
@danielfireman danielfireman merged commit beb5eee into main Nov 8, 2022
@danielfireman danielfireman deleted the test_improvements branch November 8, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cuducos cuducos cuducos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielfireman @cuducos