-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ociclient: require digests for descriptors
In PR #29, I suggested that we should verify that the tests fail when the fix was not applied, but the tests did not fail in that case. It turns out that's because the client was being a bit too slack about requiring digests in responses, meaning that the client succeeded even when it should have failed. This change makes `ociclient.descriptorFromResponse` a little more stringent about digests, and I've explicitly verified that when the changes in #29 are reverted, the tests do in fact fail as expected. Signed-off-by: Roger Peppe <rogpeppe@gmail.com> Change-Id: Ic7352b572593a60dc2209193fdd64bf2e4235af9 Reviewed-on: https://review.gerrithub.io/c/cue-labs/oci/+/1191111 TryBot-Result: CUE porcuepine <cue.porcuepine@gmail.com> Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
- Loading branch information
Showing
3 changed files
with
18 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters