-
Notifications
You must be signed in to change notification settings - Fork 276
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
internal/core/eval: reduce per-node allocations
Removed resultNode from nodeShared and reuse allocations of nodeShared and nodeContext. Reduces running time of all tests by about 15%. This also simplifies disjunction handling and prepares for optimizing disjunction handling further. Note that with this change, it would be possible to merge nodeShared and nodeContext into a single type. This is left for later work. This also delays the creation of the arcMap to when it is really needed, avoiding another allocation for the majority of nodes. Change-Id: I40f39dbc5d07992cbc3490c4512caf9845ac1881 Reviewed-on: https://cue-review.googlesource.com/c/cue/+/7403 Reviewed-by: CUE cueckoo <cueckoo@gmail.com> Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>
- Loading branch information
Showing
4 changed files
with
196 additions
and
123 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.