-
Notifications
You must be signed in to change notification settings - Fork 276
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
pkg/internal: fix decimal and string list errors
Fixes regression introduced in 0ffde15. Problem was bug that converted an incomplete error to a permanent error. The solution is to not use the public API, but rather the internal one, and pass errors up more directly. This also fixes a bug with slice, which masked unevaluated arcs with a finalized one. This issue did not surface before as the API would proactively evaluate arcs. For this reason (and because slices are officially not supported), the lower level implementations now defensively still proactively evaluate, even if this should not be necessary. Fixes #776 Change-Id: I76f9e36cf28d5bde0f0a629958c7d07b909d48f5 Reviewed-on: https://cue-review.googlesource.com/c/cue/+/8742 Reviewed-by: CUE cueckoo <cueckoo@gmail.com> Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>
- Loading branch information
Showing
3 changed files
with
283 additions
and
62 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.