internal/cuedebug: usurp some evaluator debug flags

This required moving setting the default value only when
there actually is a default value to avoid a crash for
non-boolean values.

Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: I70b8826a838ae0263deeadffce71ba706d39dced
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1193620
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Unity-Result: CUE porcuepine <cue.porcuepine@gmail.com>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>

internal/core/adt/context.go

@@ -30,22 +30,9 @@ import (
 	"cuelang.org/go/cue/stats"
 	"cuelang.org/go/cue/token"
 	"cuelang.org/go/internal"
+	"cuelang.org/go/internal/cuedebug"
 )
 
-type DebugFlags struct {
-	// Strict sets whether extra aggressive checking should be done.
-	// This should typically default to true for pre-releases and default to
-	// false otherwise.
-	Strict bool
-
-	// LogEval sets the log level for the evaluator.
-	// There are currently only two levels:
-	//
-	//	0: no logging
-	//	1: logging
-	LogEval int
-}
-
 // DebugSort specifies that arcs be sorted consistently between implementations.
 //
 //	0: default
@@ -218,7 +205,7 @@ type OpContext struct {
 	Runtime
 	Format func(Node) string
 
-	DebugFlags
+	cuedebug.Config
 	Version internal.EvaluatorVersion // Copied from Runtime
 
 	taskContext

internal/cuedebug/debug.go

@@ -11,6 +11,18 @@ var Flags Config
 
 type Config struct {
 	HTTP bool
+
+	// Strict sets whether extra aggressive checking should be done.
+	// This should typically default to true for pre-releases and default to
+	// false otherwise.
+	Strict bool
+
+	// LogEval sets the log level for the evaluator.
+	// There are currently only two levels:
+	//
+	//	0: no logging
+	//	1: logging
+	LogEval int
 }
 
 // Init initializes Flags. Note: this isn't named "init" because we

internal/envflag/flag.go

@@ -39,8 +39,8 @@ func Init[T any](flags *T, envVar string) error {
 				return fmt.Errorf("invalid default bool value for %s: %v", field.Name, err)
 			}
 			defaultValue = v
+			fv.Field(i).SetBool(defaultValue)
 		}
-		fv.Field(i).SetBool(defaultValue)
 		indexByName[strings.ToLower(field.Name)] = i
 	}