internal/core/validate: use defaults in concrete mode

Change-Id: Ib9275fe6bfccc272d142b853ae7b6d6555a63098
Reviewed-on: https://cue-review.googlesource.com/c/cue/+/6654
Reviewed-by: CUE cueckoo <cueckoo@gmail.com>
Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>

internal/core/validate/validate.go

@@ -82,12 +82,14 @@ func (v *validator) validate(x *adt.Vertex) {
 			return
 		}
 
-	} else if v.Concrete && v.inDefinition == 0 && !adt.IsConcrete(x) {
-		// TODO: use ValueError to get full path.
-		v.add(&adt.Bottom{
-			Code: adt.IncompleteError,
-			Err:  v.ctx.Newf("incomplete value %v", v.ctx.Str(x.Value)),
-		})
+	} else if v.Concrete && v.inDefinition == 0 {
+		x := x.Default()
+		if !adt.IsConcrete(x) {
+			v.add(&adt.Bottom{
+				Code: adt.IncompleteError,
+				Err:  v.ctx.Newf("incomplete value %v", v.ctx.Str(x.Value)),
+			})
+		}
 	}
 
 	for _, a := range x.Arcs {

internal/core/validate/validate_test.go

@@ -143,6 +143,12 @@ y: incompatible values 4 and 2`,
 		x: 1 & 2
 		`,
 		out: "eval\nx: incompatible values 2 and 1",
+	}, {
+		desc: "consider defaults for concreteness",
+		cfg:  &Config{Concrete: true},
+		in: `
+		x: *1 | 2
+		`,
 	}}
 
 	r := runtime.New()