Skip to content

Commit

Permalink
cuepls: minimal changes to telemetry
Browse files Browse the repository at this point in the history
As part of "vendoring" the golang.org/x/tools/... packages (including
the gopls module) we also "vendored" a dependency on
golang.org/x/telemetry.

The goal is to (at some point in a later commit) enable telemetry on an
opt-in basis.

For now, make minimal changes to ensure that we do not use Go
configuration/endpoints for telemetry, even though there is no way to
turn it on right now. That will follow in a later CL.

For #142

Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: I775de9799ad9f5c996a1d4bfb2d04bac25c44d13
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1174166
TryBot-Result: CUEcueckoo <cueckoo@gmail.com>
Unity-Result: CUE porcuepine <cue.porcuepine@gmail.com>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
  • Loading branch information
myitcv committed Feb 14, 2024
1 parent 09f11f9 commit ae69f66
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion internal/golangorgx/telemetry/internal/telemetry/mode.go
Expand Up @@ -36,7 +36,7 @@ func init() {
if err != nil {
return
}
gotelemetrydir := filepath.Join(cfgDir, "go", "telemetry")
gotelemetrydir := filepath.Join(cfgDir, "cue", "telemetry")
LocalDir = filepath.Join(gotelemetrydir, "local")
UploadDir = filepath.Join(gotelemetrydir, "upload")
ModeFile = ModeFilePath(filepath.Join(gotelemetrydir, "mode"))
Expand Down
2 changes: 1 addition & 1 deletion internal/golangorgx/telemetry/internal/upload/run.go
Expand Up @@ -115,7 +115,7 @@ func NewUploader(config *telemetry.UploadConfig) *Uploader {
LocalDir: it.LocalDir,
UploadDir: it.UploadDir,
ModeFilePath: it.ModeFile,
UploadServerURL: "https://telemetry.go.dev/upload",
UploadServerURL: "https://telemetry.cue.works/upload",
StartTime: time.Now().UTC(),
}
}
Expand Down

0 comments on commit ae69f66

Please sign in to comment.