cue/testdata: update todos on various tests

Some of the test results were changed without updating
the todos accordingly.

Issue #2884

Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: I781c9dd6afab7ac9784751a0288db9e520cf4ad4
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1193841
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Unity-Result: CUE porcuepine <cue.porcuepine@gmail.com>

cue/testdata/comprehensions/pushdown.txtar

@@ -1720,10 +1720,6 @@ Retain: 101
 Unifications: 406
 Conjuncts:    652
 Disjuncts:    476
--- diff/todo/p1 --
-embed.fail1.p: error not propagated to parent.
-provideIncompleteSuccess.t2.a.c.d: missing error.
-A bit esoteric, but should work.
 -- diff/todo/p2 --
 Missing empty disjunction message.
 provideIncompleteSuccess.t2.a.c.d: missing error: probably correct.

cue/testdata/cycle/comprehension.txtar

@@ -1506,11 +1506,9 @@ Unifications: 832
 Conjuncts:    2525
 Disjuncts:    1404
 -- diff/todo/p0 --
-issue779.X: invalid cycle error.
-selfReferential.list.panels: invalid incomplete error.
-selfReferential.acrossOr: many errors
-issue1666.*.f2.a.t: invalid structural cycle
-issue1881: differences
+selfReferential.list.panels: invalid incomplete error: related to "or" builtin
+selfReferential.acrossOr: many errors: related to "or" builtin
+issue1881: differences: related to "or" builtin
 ...
 -- out/eval --
 Errors:

cue/testdata/cycle/constraints.txtar

@@ -933,8 +933,8 @@ diff old new
                  }
                }
              }
--- diff/todo/p1 --
-issue1503: cycle detected too late
+-- diff/todo/p2 --
+issue1503: cycle detected too late (but not super late)
 selfTriggerCycle.t1.a.b.b: cycle detected slightly too late
 -- out/eval --
 Errors:

cue/testdata/cycle/structural.txtar

@@ -2599,18 +2599,22 @@ Reducer:
 	a: c: r
 -- diff/todo/p2 --
 TODO(share): fix the following bug once we have structure sharing.
-b4.b: Structural error converted to eval error.
 d3.config: should structural cycle be reported?
-b7.b.0.0: sructural cycle nested one too deep.
-b12b: structural cycle nested too deep.
 p3.a.a: field not allowed incorrect?
-p2.#T.a.b.link: error not propagated up. Could be a structure sharing
-   artifact, though, in which case it is probably okay.
+p2.a.a.one.link.a.two.link: error not propagated up. Could be a structure
+   sharing artifact, though, in which case it is probably okay.
 -- diff/todo/p3 --
 n4: Reordering.
+b12b: reported at correct level, but investigate if it is not processing
+    too deep anyway.
 -- diff/explanation --
 Structural cycles are reported in all chains. compared to old implementation.
 d3.config: reports cycle at correct position.
+b4.b: Structural error converted to eval error: there is both a structural and
+   eval error at this field. The newly reported error is correct.
+b7.b.0.0: structural cycle nested one too deep: the eval error takes precedence.
+   The cycle is reported at the correct level according to the spec.
+
 -- out/eval --
 Errors:
 a1.f.0: structural cycle

cue/testdata/eval/conjuncts.txtar

@@ -240,8 +240,6 @@ Retain: 22
 Unifications: 45
 Conjuncts:    135
 Disjuncts:    86
--- diff/todo/p0 --
-conjunct.t3: Unexpanded disjunction.
 -- diff/todo/p3 --
 Missing error position.
 -- diff/explanation --