Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test goreleaser setup #1124

Closed
myitcv opened this issue Jul 21, 2021 · 2 comments
Closed

ci: test goreleaser setup #1124

myitcv opened this issue Jul 21, 2021 · 2 comments
Labels
NeedsDesign Functionality seems desirable, but not sure how it should look like.

Comments

@myitcv
Copy link
Member

myitcv commented Jul 21, 2021

Depends on goreleaser/goreleaser#2355. Ideally we want to add a step to at least one entry in the regular build matrix (but perhaps not all because it will add time) to dry-run the goreleaser setup. Per goreleaser/goreleaser#2355 (comment), it would be ideal if we could assert the behaviour against some sort of golden file.

cc @caarlos0

@myitcv myitcv added the NeedsDesign Functionality seems desirable, but not sure how it should look like. label Jul 21, 2021
@mvdan
Copy link
Member

mvdan commented Jun 13, 2023

I tihnk @myitcv and I did this in https://review.gerrithub.io/c/cue-lang/cue/+/549190 - pushes to branches now run goreleaser in "snapshot" mode, until something like goreleaser test is supported by upstream. I think we could close this issue on our side, and watch goreleaser/goreleaser#2355 to consider switching to that when available?

@myitcv myitcv added the zGarden label Jun 15, 2023
@mvdan
Copy link
Member

mvdan commented Jan 1, 2024

^ Doing the above. I will send a tiny CL to link to the upstream issue via a TODO, however, as I think keeping a small reminder with a link is best. I don't think we need to keep this issue open, as the goreleaser setup is being tested well enough now.

@mvdan mvdan removed the zGarden label Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsDesign Functionality seems desirable, but not sure how it should look like.
Projects
None yet
Development

No branches or pull requests

2 participants