Skip to content

Commit

Permalink
internal/ci: add a TODO about "goreleaser test"
Browse files Browse the repository at this point in the history
This adds a reminder TODO so we don't forget,
and links to the upstream issue for easy reference.
The issue can be closed now, since we test the goreleaser setup
well enough now via "goreleaser release --snapshot".

Closes #1124.

Signed-off-by: Daniel Martí <mvdan@mvdan.cc>
Change-Id: I38c8bb9afd47dfd7e966eae60a3ccdcf0a4d614f
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1174152
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Unity-Result: CUE porcuepine <cue.porcuepine@gmail.com>
Reviewed-by: Paul Jolly <paul@myitcv.io>
  • Loading branch information
mvdan committed Jan 10, 2024
1 parent 20a4505 commit 21086d0
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions internal/ci/goreleaser/goreleaser_tool.cue
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,10 @@ command: release: {
// Only run the full release when running on GitHub actions for a release tag.
// Keep in sync with repo.releaseTagPattern, which is a globbing pattern
// rather than a regular expression.
//
// TODO: Once there is a "goreleaser test" command,
// switch to that instead of our workaround via "goreleaser release --snapshot".
// See: https://github.com/goreleaser/goreleaser/issues/2355
if _githubRef !~ "refs/tags/\(repo.releaseTagPrefix).*" {
"--snapshot"
},
Expand Down

0 comments on commit 21086d0

Please sign in to comment.