-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cue: some deprecation notices suggest other APIs which are also deprecated #1735
Comments
I'm not quite sure what the issue/question is here?
The doc comments you have quoted are not, to my knowledge, visible by virtue of being defined against So it this perhaps just a code-level clean up you're proposing? |
Each of the functions are still exported. I was able to see these in vscode via code completion. I found it hard to follow the recursive deprecation. |
They are indeed hidden from the docs, e.g. see https://pkg.go.dev/cuelang.org/go/cue@master#Runtime. That said, we can fix up the deprecation notices to directly point to non-deprecated APIs. I'll send a patch. |
In APIs like Runtime.Compile, point to non-deprecated alternatives, rather than pointing to methods which are themselves also deprecated. While here, tidy up other deprecated notes so that they use doc links. Also note that Instance.LookupField had two deprecation notices; only the second seems to have been up to date. Fixes #1735. Signed-off-by: Daniel Martí <mvdan@mvdan.cc> Change-Id: Ie8d8ba3e76855f36d3746a1e65c9d8af17737dbc
cue/cue/build.go
Lines 60 to 61 in 87408d7
cue/cue/build.go
Lines 104 to 106 in 87408d7
The text was updated successfully, but these errors were encountered: