Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/cue: mod edit should not parse module file in strict mode #3211

Closed
rogpeppe opened this issue Jun 11, 2024 · 0 comments
Closed

cmd/cue: mod edit should not parse module file in strict mode #3211

rogpeppe opened this issue Jun 11, 2024 · 0 comments
Labels
modules Issues related to CUE modules and the experimental implementation NeedsFix

Comments

@rogpeppe
Copy link
Member

What version of CUE are you using (cue version)?

$ cue version
 v0.0.0-20240610152000-475f692480d6

Does this issue reproduce with the latest stable release?

Yes (v0.9.0)

What did you do?]

exec cue mod edit --source=git
-- cue.mod/module.cue --
module: "test.example/foo"
language: version: "v0.9.0"

What did you expect to see?

A passing test

What did you see instead?

[stderr]
module path "test.example/foo" in $WORK/cue.mod/module.cue does not contain major version
[exit status 1]
FAIL: /tmp/x.txtar:1: unexpected command failure
@rogpeppe rogpeppe added NeedsFix modules Issues related to CUE modules and the experimental implementation labels Jun 11, 2024
cueckoo pushed a commit that referenced this issue Jun 12, 2024
We do not want to prevent editing a module.cue file
when the strictness criteria are not met.

Fixes #3211.

Signed-off-by: Roger Peppe <rogpeppe@gmail.com>
Change-Id: I31991846db9a1815eeaa4cc41720e0943e74e4a0
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1196180
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Unity-Result: CUE porcuepine <cue.porcuepine@gmail.com>
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1196234
Reviewed-by: Paul Jolly <paul@myitcv.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
modules Issues related to CUE modules and the experimental implementation NeedsFix
Projects
Archived in project
Status: v0.9.1
Development

No branches or pull requests

1 participant