This repository has been archived by the owner on Nov 18, 2021. It is now read-only.
start using GitHub Actions as CI #147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now, this tests on Ubuntu, MacOS, and Windows, both on the latest Go 1.12 and 1.13. We run the tests both with and without -race. Three tests needed updating, since they exec the system's "echo" binary. On Windows, that may use CRLF line endings, which happened on GitHub Actions. To fix that, match the output with a line regular expression, instead of via an entire stdout file with LF line endings. Finally, remove the AppVeyor badge and cloudbuild file, as we won't be needing those anymore. Fixes #144.
|
Success! Here are the six job builds on my fork: https://github.com/mvdan/cue/commit/488419cd3102ab7245721a85bd75aaa3b60116ce/checks?check_suite_id=253647069 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, this tests on Ubuntu, MacOS, and Windows, both on the latest Go
1.12 and 1.13. We run the tests both with and without -race.
Three tests needed updating, since they exec the system's "echo" binary.
On Windows, that may use CRLF line endings, which happened on GitHub
Actions. To fix that, match the output with a line regular expression,
instead of via an entire stdout file with LF line endings.
Finally, remove the AppVeyor badge and cloudbuild file, as we won't be
needing those anymore.
Fixes #144.