Skip to content
This repository has been archived by the owner on Jan 31, 2022. It is now read-only.

Type Hierarchy #126

Closed
j-bai opened this issue Jan 15, 2021 · 2 comments
Closed

Type Hierarchy #126

j-bai opened this issue Jan 15, 2021 · 2 comments

Comments

@j-bai
Copy link

j-bai commented Jan 15, 2021

In the given example, definitions of xaxis and yaxis are obviously incorrect: for all points on xaxis, their y coordinates should always be 0; similarly, for all points on yaxis, their x coordinates should always be 0. Therefore, content of types.cue should be as below:

point: {
x: number
y: number
}

xaxis: point
xaxis: y: 0

yaxis: point
yaxis: x: 0

origin: xaxis & yaxis

cueckoo pushed a commit to cuelang/cue that referenced this issue Feb 13, 2021
@j-bai raised cuelang/cuelang.org#126, pointing out that the roles of `xaxis` and `yaxis` are backwards. This addresses the issue.

Closes #711
#711

GitOrigin-RevId: 186399f
Change-Id: I439cf405ce4174d75917c550c9ef3b91ff9ab54c
cueckoo pushed a commit to cuelang/cue that referenced this issue Feb 13, 2021
@j-bai raised cuelang/cuelang.org#126, pointing out that the roles of `xaxis` and `yaxis` are backwards. This addresses the issue.

Closes #711
#711

GitOrigin-RevId: 186399f
Change-Id: I439cf405ce4174d75917c550c9ef3b91ff9ab54c
Reviewed-on: https://cue-review.googlesource.com/c/cue/+/8622
Reviewed-by: CUE cueckoo <cueckoo@gmail.com>
Reviewed-by: Marcel van Lohuizen <mpvl@golang.org>
@myitcv
Copy link
Contributor

myitcv commented Mar 12, 2021

This was resolved by a commit referenced above.

@myitcv myitcv closed this as completed Mar 12, 2021
@cueckoo
Copy link

cueckoo commented Jul 3, 2021

This issue has been migrated to https://github.com/cue-lang/cuelang.org/issues/126.

For more details about CUE's migration to a new home, please see cue-lang/cue#1078.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants