Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mejorar tipado de definición de routes #696

Closed
2 tasks done
rolivencia opened this issue Apr 11, 2024 · 3 comments · Fixed by #764
Closed
2 tasks done

Mejorar tipado de definición de routes #696

rolivencia opened this issue Apr 11, 2024 · 3 comments · Fixed by #764
Assignees
@luz-ojeda
Labels
🛠️ tooling Modifica herramientas y sus implementaciones en la app
Milestone
2.4.2

Comments

@rolivencia
Copy link
Member

rolivencia commented Apr 11, 2024 •
edited

Descripción

A fin de robustecer el tipado, se sugiere la introducción de template-based types para prefijar las diferentes routes referenciadas en la aplicación.

Tareas

  • Agregar tipado basado en enums en app.routes.ts.
  • Agregar tipado basado en enums para URLs de API en story.service.ts y storylist.service.ts.
@rolivencia rolivencia added the 🛠️ tooling Modifica herramientas y sus implementaciones en la app label Apr 11, 2024
@rolivencia rolivencia added this to the 2.4.2 milestone May 10, 2024
@rolivencia rolivencia removed this from the 2.4.2 milestone May 28, 2024
@luz-ojeda
Copy link
Contributor

La tomo

@Addin
Copy link
Contributor

Addin commented Jun 6, 2024

Asignado @luz-ojeda.

@rolivencia rolivencia added this to the 2.4.2 milestone Jun 7, 2024
rolivencia added a commit that referenced this issue Jun 7, 2024
@rolivencia
Merge pull request #764 from luz-ojeda/696-usar-template-literal-type…
67016c5 
…s-para-prefijar-routes

[#696] - Usar template literal types para prefijar routes
@rolivencia
Copy link
Member Author

Por alguna razón no se cerró luego del merge. Procedo a cerrar el issue.

@rolivencia rolivencia reopened this Jun 10, 2024
@rolivencia rolivencia linked a pull request Jun 10, 2024 that will close this issue
[#696] - Usar template literal types para prefijar routes #764
Merged
@rolivencia rolivencia changed the title Usar template literal types para prefijar routes Mejorar tipado de definición de routes Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luz-ojeda luz-ojeda

Labels
🛠️ tooling Modifica herramientas y sus implementaciones en la app
Projects
None yet
Milestone
2.4.2
Development

Successfully merging a pull request may close this issue.

[#696] - Usar template literal types para prefijar routes luz-ojeda/cuentoneta
3 participants
@Addin @rolivencia @luz-ojeda