Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agregar tipado en función AuthorService -> getBySlug #833

Closed
3 tasks done
Tracked by #697
rolivencia opened this issue Jun 30, 2024 · 0 comments · Fixed by #860
Closed
3 tasks done
Tracked by #697

Agregar tipado en función AuthorService -> getBySlug #833

rolivencia opened this issue Jun 30, 2024 · 0 comments · Fixed by #860
Assignees
@luz-ojeda
Labels
🛠️ tooling Modifica herramientas y sus implementaciones en la app
Milestone
2.4.3

Comments

@rolivencia
Copy link
Member

rolivencia commented Jun 30, 2024 •
edited by luz-ojeda
Loading

Descripción

Se requiere tipar mediante Sanity TypeGen los resultados del fetch del cliente de Sanity definido en el método getBySlug del archivo api/story/author.service.ts.

Tareas

  • Definir consulta literal en GROQ utilizando el prefijo groq en el archivo author.query.ts, abstrayendo la definición actual de la consulta hecha en author.service.ts.
  • Generar tipado para la consulta utilizando Sanity TypeGen.
  • Asignar tipo generado al resultado de la operación client.fetch
@rolivencia rolivencia mentioned this issue Jun 30, 2024
Open
13 tasks
@rolivencia rolivencia added the 🛠️ tooling Modifica herramientas y sus implementaciones en la app label Jun 30, 2024
@rolivencia rolivencia changed the title Agregar tipado en método getBySlug Agregar tipado en función getBySlug Jun 30, 2024
@rolivencia rolivencia changed the title Agregar tipado en función getBySlug Agregar tipado en función AuthorService -> getBySlug Jul 1, 2024
@rolivencia rolivencia added this to the 2.4.3 milestone Jul 1, 2024
@luz-ojeda luz-ojeda self-assigned this Jul 1, 2024
luz-ojeda added a commit that referenced this issue Jul 18, 2024
@luz-ojeda
[#833] Definir consulta literal usando groq para author by slug
b1713b7
luz-ojeda added a commit that referenced this issue Jul 18, 2024
@luz-ojeda
[#833] Generar tipos para query de autor y utilizar en author service
3cefa91
@luz-ojeda luz-ojeda linked a pull request Jul 18, 2024 that will close this issue
[#833] Agregar tipado en función author service getBySlug #860
Merged
rolivencia added a commit that referenced this issue Jul 23, 2024
@rolivencia
Merge pull request #860 from cuentoneta/833-agregar-tipado-en-función…
baf8b9d 
…-authorservice-getbyslug

[#833] Agregar tipado en función author service getBySlug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luz-ojeda luz-ojeda

Labels
🛠️ tooling Modifica herramientas y sus implementaciones en la app
Projects
None yet
Milestone
2.4.3
Development

Successfully merging a pull request may close this issue.

[#833] Agregar tipado en función author service getBySlug cuentoneta/cuentoneta
2 participants
@rolivencia @luz-ojeda