Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geo menu updates #161

Merged
merged 10 commits into from
Aug 8, 2015
Merged

Geo menu updates #161

merged 10 commits into from
Aug 8, 2015

Conversation

mapsam
Copy link
Member

@mapsam mapsam commented Jul 11, 2015

This pull request has three major changes/updates:

  1. New side_menu space for placing geo operations. This change will allow us to build a more effective visual response to operations being available based on the user's data loaded in the layer list.
  2. Updated location of geo forms for these side menus that is built on the menu location. See the screenshot below. Other menus still load in the center of the screen.
  3. Incorporation of Geoglyphs, an icon set for GIS applications built by CUGOS. It's under development, but can be contributed over at http://github.com/cugos/geoglyphs

screen shot 2015-07-10 at 8 45 22 pm

@mapsam
Copy link
Member Author

mapsam commented Jul 11, 2015

Hmm getting some errors on my local build that aren't showing up in tests. Going to investigate ...

@mapsam
Copy link
Member Author

mapsam commented Jul 11, 2015

Yay, tests are passing! @alukach what's the procedure for debugging codeship?

@alukach
Copy link
Member

alukach commented Jul 11, 2015

@mapsam Re: codeship, looks like I may have left some bad data in the codeship testing script. I'll fix that really quickly.

@alukach
Copy link
Member

alukach commented Jul 11, 2015

@mapsam Good to go! Going to make a PR to put codeship build steps within the repo.

@mapsam
Copy link
Member Author

mapsam commented Jul 12, 2015

Boom! 💥

Thanks for the quick fix!

@alukach
Copy link
Member

alukach commented Jul 12, 2015

Merged in master to get Codeship builds to pass

@mapsam
Copy link
Member Author

mapsam commented Jul 12, 2015

👍 thank you, sir!

@mapsam
Copy link
Member Author

mapsam commented Jul 12, 2015

Actually, I'm going to add the in-progress label back since I should probably do a bit more work on the Geoglyphs side of things (i.e. currently a broken image). Will try and get some of these fixed up today!

@mapsam mapsam removed the in progress label Aug 8, 2015
mapsam added a commit that referenced this pull request Aug 8, 2015
@mapsam mapsam merged commit 5d53f54 into master Aug 8, 2015
@mapsam mapsam deleted the geo-menu-updates branch August 8, 2015 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants