-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Input templates #63
Closed
Closed
Input templates #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a first attempt at generating forms when the user clicks an operation. My original thought was to use Handlebars.js or Mustache.js to do this, but wanted to see what the burden was of building our own forms. It's not the most beautiful result - but I think it does a good job at continuing to keep all of the information in one place when we register the turf functions.
What Changed?
Forms.js
under/menu
- this is a submodule of menu, since most of the interaction with forms will come out of interacting with the menu specifically.operation-click
to theAppController.js
so we can do things when a user clicks those buttons. Right now the only operation that runs when that event fires is theForm.render()
function which takes in an operation info, i.e.buffer
.Let me know what you think about this!