Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ handle executable schema option #52

Merged
merged 8 commits into from Jan 8, 2021
Merged

✨ handle executable schema option #52

merged 8 commits into from Jan 8, 2021

Conversation

EmrysMyrddin
Copy link
Collaborator

No description provided.

nlepage
nlepage approved these changes Jan 7, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
server/src/graphql.spec.ts Outdated Show resolved Hide resolved
server/src/graphql.spec.ts Outdated Show resolved Hide resolved
server/src/graphql.ts Outdated Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
nlepage
nlepage requested changes Jan 8, 2021
View reviewed changes
Copy link
Member

@nlepage nlepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one

server-postgres/src/exports.ts Show resolved Hide resolved
server-postgres/src/index.ts Outdated Show resolved Hide resolved
server/src/exports.ts Show resolved Hide resolved
server/src/exports.ts Outdated Show resolved Hide resolved
server/src/graphql.ts Show resolved Hide resolved
server/src/make-executable-schema.ts Outdated Show resolved Hide resolved
server/src/make-executable-schema.ts Outdated Show resolved Hide resolved
server/src/server.ts Outdated Show resolved Hide resolved
server/src/server.ts Outdated Show resolved Hide resolved
@EmrysMyrddin @nlepage
Update package.json
cf2c255 
Co-authored-by: Nicolas Lepage <19571875+nlepage@users.noreply.github.com>
EmrysMyrddin
EmrysMyrddin commented Jan 8, 2021
View reviewed changes
tsconfig-node12.json Outdated Show resolved Hide resolved
EmrysMyrddin
EmrysMyrddin commented Jan 8, 2021
View reviewed changes
tsconfig-node14.json Outdated Show resolved Hide resolved
EmrysMyrddin and others added 3 commits January 8, 2021 14:32
@EmrysMyrddin @nlepage
Apply suggestions from code review
e5e867e 
Co-authored-by: Nicolas Lepage <19571875+nlepage@users.noreply.github.com>
@EmrysMyrddin
👌
bf0167b
@EmrysMyrddin
👌
a42473d
@nlepage nlepage self-requested a review January 8, 2021 13:46
@EmrysMyrddin EmrysMyrddin merged commit 0528307 into master Jan 8, 2021
@EmrysMyrddin EmrysMyrddin deleted the server/executable-schema-compatibility branch January 8, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlepage nlepage nlepage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EmrysMyrddin @nlepage