Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest curl on "dev" branch not firing callbacks #14

Closed
asilvas opened this issue Aug 30, 2011 · 2 comments
Closed

Latest curl on "dev" branch not firing callbacks #14

asilvas opened this issue Aug 30, 2011 · 2 comments
Assignees
Milestone

Comments

@asilvas
Copy link
Contributor

asilvas commented Aug 30, 2011

No code changes on my side, just getting the latest (unpackaged, unminified) curl.js is not firing my modules callback.

curl(["js!jquery.js"], function() { }); // loads, and performs callback OK
curl(["module1"], function() { }); // loads, but does NOT callback

// module1.js
define("module1", ["js!jquery.js", "link!module1.css"], function() { }); // all resources load, but does NOT callback

Being everything is loading, just not calling back, hard to say if the issue is in curl or the "js!" plugin. I removed the "link!" dependency temporarily to verify it was not the culprit.

@asilvas
Copy link
Contributor Author

asilvas commented Aug 30, 2011

A little more info. If I comment ouf the first curl, it will work just fine. The first line is done as a form of pre-loader, but is preventing the define call from calling back once complete.

@unscriptable
Copy link
Member

this is fixed in dev branch and added test case. thanks for catching this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants