Document and test when/node/function #90

Merged
merged 12 commits into from Jan 25, 2013

Conversation

Projects
None yet
2 participants
Contributor

renato-zannon commented Jan 18, 2013

Part of #73.

Way late, but there it is! I think the createCallback docs need to be improved though, I couldn't think about a good use case for it...

Kinda-off-topic: I should be able to finish the when/callback stuff by tomorrow :)

Owner

briancavalier commented Jan 18, 2013

Awesome, can't wait to dig into this tomorrow :) thanks!

Nice example

Hmm, very minor: people might tend to call the node/function module variable whatever they see us calling it. Since the cujojs naming scheme tends to use camel case rather than underscores, how about we use something without an underscore?

How about nodefn ... just nix the underscore :)

Owner

briancavalier commented Jan 18, 2013

I wonder if people would find 'nodeback' or 'createNodeback' to be a more intuitive name than 'createCallback'. I don't mind 'createCallback', but just want to see if you have any thoughts.

Owner

briancavalier commented Jan 18, 2013

Overall, this looks great, once again. Have a look at the very minor comments, and then I think we can get this merged.

Contributor

renato-zannon commented Jan 19, 2013

Do you have any particular use case for createCallback that isn't covered by bind? Maybe it will throw some light at whether it is a good name or not :)

Owner

briancavalier commented Jan 23, 2013

Argh, github didn't notify me about your node_fn -> nodefn update! Sorry about that! I'll look it over asap.

Heh, honestly, I can't really think of any good use cases for createCallback. Maybe after its in the wild, people will discover some ... of course, that means it'll be harder to change the name. Oh well, in the absence of any real motivation or evidence for changing it, let's just go with it as is :)

briancavalier added a commit that referenced this pull request Jan 25, 2013

Merge pull request #90 from riccieri/node
Document and test when/node/function

@briancavalier briancavalier merged commit 5b6a766 into cujojs:functional Jan 25, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment