Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document and test when/node/function #90

Merged
merged 12 commits into from Jan 25, 2013

Conversation

renato-zannon
Copy link
Contributor

Part of #73.

Way late, but there it is! I think the createCallback docs need to be improved though, I couldn't think about a good use case for it...

Kinda-off-topic: I should be able to finish the when/callback stuff by tomorrow :)

@briancavalier
Copy link
Member

Awesome, can't wait to dig into this tomorrow :) thanks!

@briancavalier
Copy link
Member

I wonder if people would find 'nodeback' or 'createNodeback' to be a more intuitive name than 'createCallback'. I don't mind 'createCallback', but just want to see if you have any thoughts.

@briancavalier
Copy link
Member

Overall, this looks great, once again. Have a look at the very minor comments, and then I think we can get this merged.

@renato-zannon
Copy link
Contributor Author

Do you have any particular use case for createCallback that isn't covered by bind? Maybe it will throw some light at whether it is a good name or not :)

@briancavalier
Copy link
Member

Argh, github didn't notify me about your node_fn -> nodefn update! Sorry about that! I'll look it over asap.

Heh, honestly, I can't really think of any good use cases for createCallback. Maybe after its in the wild, people will discover some ... of course, that means it'll be harder to change the name. Oh well, in the absence of any real motivation or evidence for changing it, let's just go with it as is :)

briancavalier added a commit that referenced this pull request Jan 25, 2013
Document and test when/node/function
@briancavalier briancavalier merged commit 5b6a766 into cujojs:functional Jan 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants