Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logic for creating electronic materials #36

Closed
starsplatter opened this issue May 13, 2021 · 4 comments · Fixed by #38
Closed

Remove logic for creating electronic materials #36

starsplatter opened this issue May 13, 2021 · 4 comments · Fixed by #38
Assignees
Labels
P1 First priority issues

Comments

@starsplatter
Copy link
Member

starsplatter commented May 13, 2021

The presence of 981 should not cause an order to be treated as electronic, we should remove that logic.

@fereira
Copy link

fereira commented May 14, 2021

I think I have this mostly done. There is still a section of code that reads 856 datafields. Then is adds eResource data to the instance record and holdings record. Should that be commented out or removed?

@starsplatter
Copy link
Member Author

Let's comment it out.

@fereira
Copy link

fereira commented May 14, 2021

Okay....the requesters_5-records_2021-03-11.mrc file actually contains electronic resources. Should that be removed from the repo or should we keep it around for testing that the app will reject records that are for e-resources.

@starsplatter
Copy link
Member Author

I don't think they do. The have 856 fields but they are articles or descriptive links, not links to the resource.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 First priority issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants