This repository has been archived by the owner on Jan 2, 2024. It is now read-only.
Simplify logic for building/parsing LibCal & R25 space schedules #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redundant to parent key but a common pattern and should be useful in simplifying logic for updating store with parsed schedule/availability.
No need to parse/build if filtering leaves us with no eligible bookings.
Fixes bug introduced when removing whileOpen filter in #101. The unexpected side-effect of that change was that bookings which started the previous day but ran into the current day (including a booking that ends at Midnight) were no longer being filtered out so the available since opening test was failing due to an index shift (from 0 to 1). This resulted in an incorrect opening time of 12am being displayed for any space where there was booking from the previous day which ran until midnight). Clear as mud... Don't fret, this is only a temporary bandage until we refactor for early morning closings in #89.
Utilize `Object.assign()` to add any/all new keys to existing store instead of explicitly setting the schedule.
Department of redundancy reducing department...
Still need to revisit these pieces and pull out the rest of the reusable bits into a shared core but this is a good start.
Thanks to refactoring from previous commit (d2996d9).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to pull out common core, but added TODO for further refactoring at later date (#109).