pull in GA source if an account is configured #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barmintor
commented
Apr 2, 2018
elohanlon
reviewed
Apr 2, 2018
spec/features/open_now_spec.rb
Outdated
| Rails.application.secrets.delete(:analytics_key) | ||
| visit '/locations/open_now' | ||
| end | ||
| it "tracks page views" do |
There was a problem hiding this comment.
May want to change this to "doesn't track page views".
|
Documentation in README would be great, thanks! |
cgalarza
reviewed
Apr 2, 2018
There was a problem hiding this comment.
Usually when I implement a google analytics snippet, I check the environment before rendering. That way it is not rendered in a dev/test environment. I have a flag config.analytics_enabled that can be set by each environment and most of the time it's just set in the production environment. And i check that flag before rendering.
cgalarza
approved these changes
Apr 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.