Utc #54
Utc #54
Conversation
src/fromTime.js
Outdated
| @@ -0,0 +1 @@ | |||
| export default time => new Date(time) | |||
There was a problem hiding this comment.
Should we handle Invalid Date here?
|
|
||
| const clone = date => new Date(date.getTime()) | ||
|
|
||
| module.exports = { | ||
| of, |
There was a problem hiding this comment.
I guess we need to add these new functions to the docs.
There was a problem hiding this comment.
yup, but I expect a few iterations, befor we settle on how the new api should be
src/of.js
Outdated
| @@ -0,0 +1,12 @@ | |||
| const isNotNil = x => x !== undefined && x !== null | |||
There was a problem hiding this comment.
Im not fuzzed either way
src/fromTime.js
Outdated
| @@ -0,0 +1 @@ | |||
| export default time => new Date(time) | |||
There was a problem hiding this comment.
I wonder should we call this function fromUnixTime and rename unixTime to toUnixTime.
There was a problem hiding this comment.
I would be ok with that.
There was a problem hiding this comment.
though unix time is in seconds and javascript getTime is in millies
|
I think this is ready for mere. It does not include functions for translating between timezones, but I would rather add that on later. It is a breaking change. |
|
Yep, tidy up the conflicts and we're good to go. |
all functions are now using the utc version of date methods add of and fromTime functions for creation of utc dates fixed test coverage fixed testBuild addded npm run flow to curcle.yml add isInvalid check to fromTime added translation added docs for of, and fromTime
|
Done |
DO NOT MERGE!