Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errorComponent and loadingComponent options don't allow functions #19

Open
olgertse opened this issue Feb 26, 2018 · 2 comments
Open

errorComponent and loadingComponent options don't allow functions #19

olgertse opened this issue Feb 26, 2018 · 2 comments
Labels
enhancement

Comments

@olgertse
Copy link

This makes it impossible to use React functional components in errorComponent or loadingComponent options.
@theodorDiaconu
Copy link
Contributor

@od1k good point.

@justbill2020
Copy link

justbill2020 commented Jun 29, 2018 •
edited
Loading

👍 bumping this... Looks like this was broken when poll option was added...

https://github.com/cult-of-coders/grapher-react/blob/master/lib/checkOptions.js#L9-L10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@theodorDiaconu @olgertse @justbill2020