Meteor 3 #405
Open
Meteor 3 #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusccastroo
commented
May 6, 2024
| api.mainModule('redis-oplog.js', 'server'); | ||
| api.mainModule('redis-oplog.client.js', 'client'); | ||
| Package.onUse(function (api) { | ||
| api.versionsFrom(["3.0-rc.0"]); |
There was a problem hiding this comment.
We might be able to support meteor 2.12 too I think - would need to double check when we have the CI running
renanc-br
reviewed
May 7, 2024
Comment on lines
-41
to
-62
| if (!this.collection) { | ||
| throw new Meteor.Error( | ||
| `We could not find the collection instance by name: "${ | ||
| this.collectionName | ||
| }", the cursor description was: ${JSON.stringify( | ||
| cursorDescription | ||
| )}` | ||
| ); | ||
| } | ||
|
|
||
| // Here we apply the logic of changing the cursor based on the collection-level configuration | ||
| if (this.collection._redisOplog) { | ||
| const { cursor } = this.collection._redisOplog; | ||
| if (cursor) { | ||
| const context = DDP._CurrentPublicationInvocation.get(); | ||
| cursor.call( | ||
| context, | ||
| cursorDescription.options, | ||
| cursorDescription.selector | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
They were moved to an init function, we just removed from the constructor.
StorytellerCZ
requested changes
May 11, 2024
| @@ -0,0 +1,6 @@ | |||
| { | |||
| "semi": true, | |||
| "singleQuote": false, | |||
There was a problem hiding this comment.
This should be true to reduce the number of prettier changes and make it easier to review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This PR goal is to have a version that is compatible with Meteor 3.
Closes #395