Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable-anyone-launch-release #3892

Merged
merged 16 commits into from
Jul 27, 2023
Merged

Enable-anyone-launch-release #3892

merged 16 commits into from
Jul 27, 2023

Conversation

gyfchong
Copy link
Contributor

@gyfchong gyfchong commented Jul 21, 2023

Why

When Changesets opens a PR it does not trigger GitHub actions, because its token does not have permission to. This is a hack to allow one of us to trigger GitHub actions for a changesets PR by enabling automerge on the PR.

What

Updated Github Action for ci to listen for auto merge trigger which will activate the ci checks

@gyfchong gyfchong requested a review from a team as a code owner July 21, 2023 05:20
@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2023

🦋 Changeset detected

Latest commit: b7941bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@HeartSquared
Copy link
Contributor

So I'm guessing the idea of this is that it doesn't actually auto-merge unless it passes CI yeah? But I suppose if it made its way to the changeset PR, it should have passed CI so it shouldn't ever fail.

Co-authored-by: Cassandra <cassandra.tam@cultureamp.com>
@gyfchong
Copy link
Contributor Author

So I'm guessing the idea of this is that it doesn't actually auto-merge unless it passes CI yeah? But I suppose if it made its way to the changeset PR, it should have passed CI so it shouldn't ever fail.

@HeartSquared pretty much, this is what was recommended and used in FEF, so it's tested.

@gyfchong gyfchong enabled auto-merge (squash) July 21, 2023 05:28
@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2023

✨ Here is your branch preview! ✨

Last updated for commit b7941bf: add auto merge trigger to test-storybook workflow

@gyfchong gyfchong merged commit af5dbfc into main Jul 27, 2023
27 checks passed
@gyfchong gyfchong deleted the enable-anyone-launch-release branch July 27, 2023 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants