Issue 98: add ErrorPage component #3900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ef8fa99 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lisatassone
commented
Jul 24, 2023
lisatassone
commented
Jul 24, 2023
packages/components/src/ErrorPage/subcomponents/BaseErrorPage.tsx
Outdated
Show resolved
Hide resolved
lisatassone
force-pushed
the
ltassone/issue98
branch
from
b9c107d
to
e6da7bb
Compare
gyfchong
reviewed
Jul 24, 2023
packages/components/src/ErrorPage/subcomponents/BaseErrorPage.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/ErrorPage/subcomponents/BaseErrorPage.tsx
Outdated
Show resolved
Hide resolved
gyfchong
reviewed
Jul 24, 2023
lisatassone
commented
Jul 24, 2023
lisatassone
force-pushed
the
ltassone/issue98
branch
from
1058f46
to
b89293f
Compare
gyfchong
reviewed
Jul 24, 2023
gyfchong
reviewed
Jul 24, 2023
lisatassone
force-pushed
the
ltassone/issue98
branch
from
8039ae7
to
664a36a
Compare
lisatassone
commented
Jul 24, 2023
gyfchong
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This PR moves much of what was in https://github.com/cultureamp/error-pages into Kaizen as dedicated error-handling components.
This is one of the improvement opportunities mentioned here.
From here both the
error-pagesrepo andnext-templatecan be updated.https://github.com/cultureamp/kaizen-discourse/issues/98
SR ticket: https://cultureamp.atlassian.net/browse/SR2-514