Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use Storybook for interaction tests instead of Playwright #3910

Merged
merged 24 commits into from
Jul 26, 2023

Conversation

HeartSquared
Copy link
Contributor

@HeartSquared HeartSquared commented Jul 25, 2023

Why

KDS-1568

Playwright tests rely on a successfully deployed Storybook, but we have found that our branch previews deployed to AWS have at time been flaky (the contents reference will be incorrect, therefore have nothing loaded).

What

  • Install Storybook testing suite and storybook/test-runner
  • Convert our Playwright tests to either Jest or Storybook interaction tests (essentially Playwright tests under the hood)
  • Extend our Chromatic workflow to run our interaction tests based on the deployed Chromatic branch
    • While it appears that the new workflow takes a lot longer than the old Playwright flow, it is because we now test all 400+ stories, whereas Playwright used to only have 19 tests
  • Separate the PR and main branch Chromatic workflows (they have different intended workflows)
  • Remove Playwright and associated config

@changeset-bot
Copy link

changeset-bot bot commented Jul 25, 2023

🦋 Changeset detected

Latest commit: eae0efe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@HeartSquared HeartSquared marked this pull request as ready for review July 25, 2023 06:16
@HeartSquared HeartSquared requested a review from a team as a code owner July 25, 2023 06:16
@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2023

✨ Here is your branch preview! ✨

Last updated for commit 1596c0a: ci: add descriptions to workflows

package.json Show resolved Hide resolved
@gyfchong gyfchong enabled auto-merge (squash) July 26, 2023 06:22
@gyfchong gyfchong merged commit 06ad1ef into main Jul 26, 2023
27 checks passed
@gyfchong gyfchong deleted the KDS-1568/storybook--interaction-testing branch July 26, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants