III-2586 fix coding-standards

cultuurnet · Nov 8, 2018 · 79b0421 · 79b0421
1 parent 7ea6b00
commit 79b0421
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 9 deletions.
diff --git a/lib/CultureFeed/Cdb/Default.php b/lib/CultureFeed/Cdb/Default.php
@@ -86,7 +86,6 @@ public function addItem(CultureFeed_Cdb_Item_Base $item)
         $type = get_class($item);
 
         switch ($type) {
-
             case 'CultureFeed_Cdb_Item_Actor':
                 $this->items['actors'][] = $item;
                 break;
@@ -111,13 +110,14 @@ public function addItem(CultureFeed_Cdb_Item_Base $item)
      *
      * @param SimpleXMLElement $xmlElement
      *   XML element from the item to parse.
+     * @return CultureFeed_Cdb_Item_Actor|CultureFeed_Cdb_Item_Event|CultureFeed_Cdb_Item_Production|null
+     * @throws CultureFeed_Cdb_ParseException
      */
     public static function parseItem(SimpleXMLElement $xmlElement)
     {
 
         // Return the correct cdb item.
         switch ($xmlElement->getName()) {
-
             case 'event':
                 return CultureFeed_Cdb_Item_Event::parseFromCdbXml($xmlElement);
 
@@ -156,9 +156,7 @@ public function __toString()
         $dom->appendChild($cdbElement);
 
         foreach ($this->items as $type => $itemsFromType) {
-
             if ($itemsFromType) {
-
                 foreach ($itemsFromType as $item) {
                     $item->appendToDOM($cdbElement, $this->getSchemaVersion());
                 }

diff --git a/lib/CultureFeed/Cdb/Item/Page.php b/lib/CultureFeed/Cdb/Item/Page.php
@@ -397,6 +397,7 @@ public function appendToDOM(DOMElement $element)
      * @see CultureFeed_Cdb_IElement::parseFromCdbXml(SimpleXMLElement
      *     $xmlElement)
      * @return CultureFeed_Cdb_Item_Page
+     * @throws CultureFeed_Cdb_ParseException
      */
     public static function parseFromCdbXml(SimpleXMLElement $xmlElement)
     {
@@ -488,7 +489,6 @@ public static function parseFromCdbXml(SimpleXMLElement $xmlElement)
         }
 
         if (!empty($addressElement->lat) && !empty($addressElement->lon)) {
-
             $coordinates = $addressElement->lat . '-' . $addressElement->lon;
             if ($coordinates != '0.0-0.0') {
                 $address->setGeoInformation(
@@ -517,7 +517,6 @@ public static function parseFromCdbXml(SimpleXMLElement $xmlElement)
         $links = array();
         if (!empty($xmlElement->links)) {
             foreach ($xmlElement->links->children() as $link) {
-
                 $url = (string) $link;
                 if (empty($url)) {
                     continue;

diff --git a/lib/CultureFeed/Cdb/Item/Production.php b/lib/CultureFeed/Cdb/Item/Production.php
@@ -31,6 +31,7 @@ class CultureFeed_Cdb_Item_Production extends CultureFeed_Cdb_Item_Base implemen
      *     $xmlElement)
      *
      * @return CultureFeed_Cdb_Item_Production
+     * @throws CultureFeed_Cdb_ParseException
      */
     public static function parseFromCdbXml(SimpleXMLElement $xmlElement)
     {
@@ -123,9 +124,7 @@ public static function parseFromCdbXml(SimpleXMLElement $xmlElement)
 
         // Set the related events for this production.
         if (!empty($xmlElement->relatedevents) && isset($xmlElement->relatedevents->id)) {
-
             foreach ($xmlElement->relatedevents->id as $relatedItem) {
-
                 $attributes = $relatedItem->attributes();
 
                 $production->addRelation(
@@ -298,7 +297,6 @@ public function appendToDOM(DOMElement $element, $cdbScheme = '3.2')
         }
 
         if (!empty($this->relations)) {
-
             $relationsElement = $dom->createElement('eventrelations');
 
             foreach ($this->relations as $relation) {