Bug: III-3252 #3
Conversation
| */ | ||
| public function setLogger(LoggerInterface $logger) | ||
| { | ||
| $this->logger = $logger; |
There was a problem hiding this comment.
It should also set it on the injected $eventListener though. Otherwise nothing will actually get logged. 😄
You'll have to make that property protected. Or alternatively (maybe better), implement the interface and method on the FilteringEventListener base class instead.
There was a problem hiding this comment.
I was also going to suggest to just remove the base class and move its logic to this class as it seems the only child class, but since it's a package there's a chance that there's other child classes in other packages / apps. So best to keep the base class.
There was a problem hiding this comment.
Hm, but the injected $eventListener only implements EventListenerInterface so I cannot call setLogger on it
Added