UBR-353 Add test for cancelTicketById and drop the return.

cultuurnet · Nov 19, 2015 · 10feaff · 10feaff
1 parent b5ebd28
commit 10feaff
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 14 deletions.
diff --git a/CultureFeed/CultureFeed/Uitpas.php b/CultureFeed/CultureFeed/Uitpas.php
@@ -313,7 +313,6 @@ public function cancelTicketSale($uitpas_number, $cdbid, $consumer_key_counter =
      *
      * @param string $ticketId The ticket id
      * @param string $consumer_key_counter The consumer key of the counter from where the request originates
-     * @return boolean
      */
     public function cancelTicketSaleById($ticketId, $consumer_key_counter = NULL);
 

diff --git a/CultureFeed/CultureFeed/Uitpas/Default.php b/CultureFeed/CultureFeed/Uitpas/Default.php
@@ -996,19 +996,13 @@ public function cancelTicketSale($uitpas_number, $cdbid, $consumer_key_counter =
      */
     public function cancelTicketSaleById($ticketId, $consumer_key_counter = NULL)
     {
-        $data = array();
-
-        if ($consumer_key_counter) {
-            $data['balieConsumerKey'] = $consumer_key_counter;
-        }
-
-        try {
-            $this->oauth_client->authenticatedPostAsXml('uitpas/cultureevent/cancel/' . $ticketId, $data);
-            return true;
-        }
-        catch (Exception $e) {
-            return false;
-        }
+      $data = array();
+
+      if ($consumer_key_counter) {
+        $data['balieConsumerKey'] = $consumer_key_counter;
+      }
+
+      $this->oauth_client->authenticatedPostAsXml('uitpas/cultureevent/cancel/' . $ticketId, $data);
     }
 
     public function getPassholderForTicketSale( CultureFeed_Uitpas_Event_TicketSale $ts, $consumer_key_counter = NULL ) {

diff --git a/CultureFeed/test/uitpas/CultureFeed_Uitpas_TicketSalesTest.php b/CultureFeed/test/uitpas/CultureFeed_Uitpas_TicketSalesTest.php
@@ -0,0 +1,21 @@
+<?php
+
+class CultureFeed_Uitpas_TicketSaleTest extends PHPUnit_Framework_TestCase {
+
+  /**
+   * @test
+   */
+  public function testCancelTicketSaleById() {
+    $oauth_client_stub = $this->getMock('CultureFeed_OAuthClient');
+    $ticketId = 1;
+    $consumerKey = 'abc';
+    $data = array('balieConsumerKey' => $consumerKey);
+
+    $oauth_client_stub->expects($this->once())
+      ->method('authenticatedPostAsXml')
+      ->with('uitpas/cultureevent/cancel/' . $ticketId, $data);
+
+    $cf = new CultureFeed($oauth_client_stub);
+    $cf->uitpas()->cancelTicketSaleById($ticketId, $consumerKey);
+  }
+}