Mark calendar summary methods as deprecated #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
getCalendarSummary()andsetCalendarSummary()onOffer. In the past there was acalendarSummaryproperty on events and places their JSON-LD, but this has been removed for some time already. Instead the/events/{id}/calsumand/places/{id}/calsumendpoints should be used (not supported by this library right now), or thecultuurnet/calendar-summary-v3library to generate it locally.Ticket: https://jira.uitdatabank.be/browse/III-3556
Note: I haven't actually removed this yet and made a 2.0 tag because I thought it might be best to wait a bit in case some other things like this pop up that should be removed. Otherwise we'll be releasing a major version every day, and there's no harm in leaving this for now.