III-3974 Get events, places and organizers by creator #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also required the email address of the creator
# Conflicts: # src/hooks/api/events.js
LucWollants
commented
May 5, 2021
bertramakers
approved these changes
May 5, 2021
There was a problem hiding this comment.
My knowledge of Typescript is very limited but as far as I can see this just added types without changing the "interface" of the functions/objects so I think that should be fine for now. If the structure of the types isn't perfect yet than that means we should refactor those models in later PRs.
The queries for the dashboard items also look correct to me. 👌
brampauwelyn
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Ticket: https://jira.uitdatabank.be/browse/III-3974