Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

III-4457 Make attendance mode searchable on events. #207

Merged
merged 11 commits into from
Apr 22, 2022
Merged

III-4457 Make attendance mode searchable on events. #207

merged 11 commits into from
Apr 22, 2022

Conversation

LucWollants
Copy link
Contributor

@LucWollants LucWollants commented Apr 21, 2022 •
edited
Loading

Added

  • Added attendanceMode as an exact match field
  • Added transformer for attendanceMode with default value of offline
  • Added attendanceMode as a multiple values query parameter

Ticket: https://jira.uitdatabank.be/browse/III-4457

@LucWollants LucWollants marked this pull request as ready for review April 21, 2022 14:27
jdrieghe
jdrieghe approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@jdrieghe jdrieghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clear incremental commits, this was a joy to review 🎉

@LucWollants LucWollants merged commit cfe13e3 into main Apr 22, 2022
@LucWollants LucWollants deleted the feature/III-4457-attendance-mode branch April 22, 2022 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdrieghe jdrieghe jdrieghe approved these changes

@bertramakers bertramakers Awaiting requested review from bertramakers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LucWollants @jdrieghe