III-2345 Validate event for equal cdbid for location and organizer. #49

LucWollants · 2017-10-20T11:42:41Z

No description provided.

…iceInterfaces.

…PHP 5.6 and PHP 7.x compatible.

…idation services.

coveralls · 2017-10-20T12:15:04Z

Coverage increased (+0.3%) to 64.199% when pulling 99fb807 on feature/III-2345 into e27ec58 on master.

coveralls · 2017-10-20T12:31:51Z

Coverage increased (+1.0%) to 64.822% when pulling b9a7a1f on feature/III-2345 into e27ec58 on master.

bertramakers · 2017-11-13T09:56:21Z

src/XML/XMLValidationServiceCollection.php

+     * XMLValidationServiceCollection constructor.
+     * @param XMLValidationServiceInterface[] $xmlValidationServices
+     */
+    public function __construct(XMLValidationServiceInterface... $xmlValidationServices)


Aangezien je hier al met variadic arguments werkt, stel ik voor om deze class te laten vallen en in de constructor van CombinedXmlValidationService gewoon met variadic arguments te werken.

bertramakers · 2017-11-13T09:59:08Z

src/XML/CombinedXmlValidationService.php

+
+namespace CultuurNet\UDB3\UDB2\XML;
+
+class CombinedXmlValidationService implements XMLValidationServiceInterface


De naamgeving die we hiervoor doorgaans hanteren in UDB3 is "Composite". Zie bv https://sourcemaking.com/design_patterns/composite

…ts instead of throwing exceptions

coveralls · 2017-11-13T15:13:48Z

Coverage increased (+1.1%) to 64.954% when pulling de0d437 on feature/III-2345 into e27ec58 on master.

coveralls · 2017-11-13T15:23:19Z

Coverage increased (+1.1%) to 64.954% when pulling 9eec2da on feature/III-2345 into e27ec58 on master.

Luc Wollants added 6 commits October 20, 2017 13:41

III-2345 Add a collection to store a typed array of XMLValidationServ…

5eb6b1d

…iceInterfaces.

III-2345 Check for catching throwable instead of TypeError so we are …

b1bf7aa

…PHP 5.6 and PHP 7.x compatible.

III-2345 The class throwable does not exist in PHP 5.6.

b4de3a0

III-2345 Check for Throwable interface instead of class.

71e21de

III-2345 Does it catch PHPUnit_Framework_Error?

2573c4f

III-2345 Add a CombinedXmlValidationService to check multiple xml val…

99fb807

…idation services.

cultuurnet deleted a comment from coveralls Oct 20, 2017

III-2345 Check for equal location and organizer cdbid.

b9a7a1f

bertramakers suggested changes Nov 13, 2017

View reviewed changes

III-2345: Rework new XML validators to return XMLValidatorError objec…

de0d437

…ts instead of throwing exceptions

III-2345 Removed obsolete namespace.

9eec2da

LucWollants merged commit 58528ea into master Nov 14, 2017

LucWollants deleted the feature/III-2345 branch November 14, 2017 07:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

III-2345 Validate event for equal cdbid for location and organizer. #49

III-2345 Validate event for equal cdbid for location and organizer. #49

LucWollants commented Oct 20, 2017

coveralls commented Oct 20, 2017 •

edited

coveralls commented Oct 20, 2017 •

edited

bertramakers Nov 13, 2017

bertramakers Nov 13, 2017

coveralls commented Nov 13, 2017 •

edited

coveralls commented Nov 13, 2017 •

edited


		namespace CultuurNet\UDB3\UDB2\XML;

		class CombinedXmlValidationService implements XMLValidationServiceInterface

III-2345 Validate event for equal cdbid for location and organizer. #49

III-2345 Validate event for equal cdbid for location and organizer. #49

Conversation

LucWollants commented Oct 20, 2017

coveralls commented Oct 20, 2017 • edited

coveralls commented Oct 20, 2017 • edited

bertramakers Nov 13, 2017

Choose a reason for hiding this comment

bertramakers Nov 13, 2017

Choose a reason for hiding this comment

coveralls commented Nov 13, 2017 • edited

coveralls commented Nov 13, 2017 • edited

coveralls commented Oct 20, 2017 •

edited

coveralls commented Oct 20, 2017 •

edited

coveralls commented Nov 13, 2017 •

edited

coveralls commented Nov 13, 2017 •

edited