Skip to content
This repository has been archived by the owner on Jun 23, 2021. It is now read-only.

III-3528 capture user info and env #36

Merged
merged 7 commits into from Oct 12, 2020
Merged

III-3528 capture user info and env #36

merged 7 commits into from Oct 12, 2020

Conversation

LucWollants
Copy link
Collaborator

@LucWollants LucWollants commented Oct 7, 2020 •
edited

Added

  • Capture user information (ID, sub, uid, uitidv1id)
  • Capture runtime information (api_key, web/cli)

Ticket: https://jira.uitdatabank.be/browse/III-3528

Note: the unit test was not modified to verify the user information or tags because the format is driven by an external integration

@coveralls
Copy link

coveralls commented Oct 7, 2020 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 02f00fa on feature/III-3528-capture-user-info into d7f95a1 on master.

@LucWollants LucWollants marked this pull request as ready for review October 9, 2020 10:59
bertramakers
bertramakers approved these changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@bertramakers bertramakers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LucWollants 💪

@LucWollants LucWollants merged commit 6b3ff4a into master Oct 12, 2020
@LucWollants LucWollants deleted the feature/III-3528-capture-user-info branch October 12, 2020 10:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bertramakers bertramakers bertramakers approved these changes

@jdrieghe jdrieghe jdrieghe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LucWollants @coveralls @bertramakers @jdrieghe