Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python-six dependency #50

Closed
pgajdos opened this issue Sep 23, 2022 · 4 comments · Fixed by #51
Closed

python-six dependency #50

pgajdos opened this issue Sep 23, 2022 · 4 comments · Fixed by #51
Labels
bug Something isn't working

Comments

@pgajdos
Copy link

pgajdos commented Sep 23, 2022

Describe the bug
Am I right that python-six dependency could be removed?
@pgajdos pgajdos added the bug Something isn't working label Sep 23, 2022
@cunla
Copy link
Owner

cunla commented Sep 25, 2022

It is used in _basefakesocket.py.

@cunla
Copy link
Owner

cunla commented Sep 27, 2022

@pgajdos is that an issue?

@pgajdos
Copy link
Author

pgajdos commented Sep 27, 2022

Well depends on how you look at it. You do not seem to support python 2 anymore and Six is a Python 2 and 3 compatibility library. From that one could deduce that six is not needed anymore.

@cunla cunla mentioned this issue Sep 27, 2022
Merged
@cunla cunla closed this as completed in #51 Sep 27, 2022
cunla added a commit that referenced this issue Sep 27, 2022
@cunla
Remove six dependency and adding host to conn_pool_args
88c0d48 
* Remove six dependency 
* Add support for param 'host'
* Add Daniel as author

Resolve #48, #50
@mcochner
Copy link

Please note that six is still also used in https://github.com/cunla/fakeredis-py/blob/master/fakeredis/_fakesocket.py#L10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove six dependency and adding host to conn_pool_args cunla/fakeredis-py
3 participants
@mcochner @cunla @pgajdos