fix:formatting of error message about missing group #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Aha! I have a workflow running now I've created the PR, just not on push. Should have checked the triggers :-) |
|
Thanks for this.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #210
I'm having some difficulties with linters (loads of errors from
both flake8 andmypy) and running the tests (one failure) before I made my changes. Probably I haven't set my environment up correctly: certainly tox didn't like it at all and failed to install anything.My new test passes, the files I've touched lint OK, so I don't think I've made things any worse. But also the github workflow hasn't run in my repo, so I can't be sure. Therefore you might want to take this into a branch of your repo first and run tests yourself!