Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for zmscore #67

Merged
merged 16 commits into from Nov 8, 2022
Merged

Conversation

the-wondersmith
Copy link
Contributor

PR adds support for ZMSCORE (available since redis-py 4.0.0) and associated Hypothesis-based tests.

pyproject.toml Outdated Show resolved Hide resolved
test/test_fakeredis6.py Outdated Show resolved Hide resolved
fakeredis/_fakesocket.py Outdated Show resolved Hide resolved
@cunla
Copy link
Owner

cunla commented Nov 6, 2022

Please also revert changes to poetry.lock

@the-wondersmith
Copy link
Contributor Author

@cunla All requested changes have been applied, I believe the PR should be ready for another (or final) review round 🙂

@cunla
Copy link
Owner

cunla commented Nov 6, 2022

Tests fail on py3.7 (see checks).
@the-wondersmith not sure if you got the previous message.. notice the checks - some scenarios fail

@the-wondersmith
Copy link
Contributor Author

the-wondersmith commented Nov 7, 2022

@cunla I saw it, just didn't have time in the day to get to it yesterday. I'll get it fixed up and re-pushed shortly.


EDIT: @cunla Fixed, pushed. 😁

@cunla
Copy link
Owner

cunla commented Nov 7, 2022

@cunla I saw it, just didn't have time in the day to get to it yesterday. I'll get it fixed up and re-pushed shortly.

EDIT: @cunla Fixed, pushed. 😁

@the-wondersmith
Still failing.. checkout the workflow logs

@the-wondersmith
Copy link
Contributor Author

@cunla Completely forgot I had act installed. I'll run the workflows locally till they pass and let you know.

@cunla
Copy link
Owner

cunla commented Nov 7, 2022

For the tests with redis-py < 4 - use the decorator to skip your tests:

@testtools.run_test_if_redispy_ver('above', '4.2.0')

@the-wondersmith
Copy link
Contributor Author

@cunla Knew I missed something when I stripped out hypothesis from the tests. Drat! 😅

Fixed and pushed.

@cunla
Copy link
Owner

cunla commented Nov 8, 2022

@the-wondersmith Please squash and merge

@cunla cunla merged commit a7208b5 into cunla:master Nov 8, 2022
@the-wondersmith the-wondersmith deleted the zmscore branch November 14, 2022 04:46
@the-wondersmith the-wondersmith mentioned this pull request Nov 14, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants