attempt to fix sidebar z-index #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I think the fix is good, @christianwach. It fixes #217 for me. It also works without the #header z-index declaration as well. Just need someone else to verify if the #header z-index is necessary or not. |
|
@r-a-y The #header z-index declaration is present because without it, if you have a menu in both "Inside Header" and "Below Header" positions, then the "Inside Header" dropdown appears under the "Below Header" menu. |
|
Thanks for the feedback, @christianwach. Forgot about the various combinations for the menus around the header. Going to merge it! Thanks again! |
r-a-y
added a commit
that referenced
this pull request
Dec 5, 2014
Fix z-index problems when using background overlays. Props @christianwach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure that this PR won't have knock-on effects on some installs, so it's intended first and foremost for testing. It is an attempt to solve the issue raised in #210 and reposted in #217
Works for me - feedback welcomed.