log file doesn't contain backend/location details #28

sumnerboy12 · 2020-07-24T00:20:08Z

Example below. All the dynamic text which is displayed in the console is not visible so you don't know what backend and backup location were processed.

Is it possible to generate more flat-file-log-friendly output via a switch/flag?

Configuring Backends

Backing Up
Files:           0 new,     0 changed,     1 unmodified
Dirs:            0 new,     0 changed,     0 unmodified
Added to the repo: 0 B

processed 1 files, 0 B in 0:04
snapshot 8a093c2a saved

Finished! ð

The text was updated successfully, but these errors were encountered:

cupcakearmy · 2020-07-24T08:38:58Z

Currently not but thats a good idea to have a flag. Will look into it the next days :)

stosem · 2020-08-06T08:10:35Z

Moreover, I can't detect failed tasks with Ansible.
autorestic always return 0 (success) as rc. Doesn't matter task was succeeded or not. And I can't catch Failed! on stdout:

Ansible stdout:

            "\u001b[4m\u001b[90m",
            "Configuring Backends\u001b[39m\u001b[24m",
            "\u001b[2K\u001b[1G\u001b[90m\u001b[4m",
            "Backing Up\u001b[24m\u001b[39m",
            "Files:           0 new,     1 changed,     0 unmodified",
            "Dirs:            0 new,     0 changed,     0 unmodified",
            "Added to the repo: 379 B",
            "",
            "processed 1 files, 2.500 KiB in 0:00",
            "snapshot bc536bdb saved null does not exist, skipping",
            "\u001b[2K\u001b[1GFiles:           0 new,     0 changed,     1 unmodified",
            "Dirs:            0 new,     0 changed,     0 unmodified",
            "Added to the repo: 0 B  ",
            "",
            "processed 1 files, 33 B in 0:00",
            "snapshot ed75da09 saved null does not exist, skipping",
            "\u001b[2K\u001b[1Gnull null",
            "\u001b[2K\u001b[1G\u001b[4m",
            "Finished!\u001b[24m 🎉"

While real output contains errors:

Configuring Backends
local-storage : Done ✓

Backing Up
test_docker ▶ local-storage : Backing up... ⏳Files:           0 new,     1 changed,     0 unmodified
Dirs:            0 new,     0 changed,     0 unmodified
Added to the repo: 379 B

processed 1 files, 2.500 KiB in 0:00
snapshot 2ce6f9b7 saved null does not exist, skipping
test_docker ▶ local-storage : Failed! (1s) null does not exist, skipping
test_home ▶ local-storage : Backing up... ⏳Files:           0 new,     0 changed,     1 unmodified
Dirs:            0 new,     0 changed,     0 unmodified
Added to the repo: 0 B

processed 1 files, 33 B in 0:00
snapshot 0ac6f2e1 saved null does not exist, skipping
test_home ▶ local-storage : Failed! (771ms) null does not exist, skipping
test_web ▶ local-storage : Backing up... ⏳null null
test_web ▶ local-storage : Failed! (5ms) null

sumnerboy12 · 2020-10-14T20:20:38Z

Would it be worth using a proper logging framework? Something like tslog perhaps? I have zero experience with TS so there may well be better options.

cupcakearmy · 2020-10-16T10:13:07Z

Hey, sry I forgot that was an issue. Probably I could rewrite the whole logging thing. It's quite ugly anyways.

cupcakearmy · 2020-11-13T20:53:24Z

So. I've added a --ci (version 0.22+) global flag which disables the interactive part.
https://autorestic.vercel.app/cli/general#--ci

@stosem you are right should not return 1 on failed. I will do that next.
Feel free to reopen if it doesnt work for you 👍
And sry for the delay, you opened the issue almost half year ago 🙈

cupcakearmy · 2020-11-13T23:53:32Z

@stosem now returns with exit code 1 if a backup fails (v0.24)

sumnerboy12 · 2020-11-15T20:11:00Z

Thanks for this @cupcakearmy and please don't apologise for implementing a feature for free on an OSS project!! It is much appreciated.

Unfortunately it doesn't seem to work as expected, see below for how my log now looks;

Configuring Backends
^[[2K^[[1G^[[2K^[[1G^[[2K^[[1G^[[2K^[[1G^[[2K^[[1G^[[2K^[[1G^[[2K^[[1G^[[2K^[[1G^[[2K^[[1G
Backing Up
Files:           0 new,     0 changed, 22690 unmodified
Dirs:            0 new,     0 changed,   605 unmodified
Added to the repo: 0 B

processed 22690 files, 86.238 GiB in 0:05
snapshot 3ac11269 saved
^[[2K^[[1GFiles:           0 new,     0 changed, 22690 unmodified
Dirs:            0 new,     0 changed,   605 unmodified
Added to the repo: 0 B

So it is now printing the output to the log file (before it wasn't showing anything), but there seems to be some sort of encoding issue? Any ideas?

cupcakearmy · 2020-11-15T20:35:11Z

Yes. But un maintained projects always make me angry 😅
I'm sure that is the coloring. I'll comment it out if using --ci

cupcakearmy · 2020-11-16T16:32:48Z

Should be fixed in 0.25 CI is building, as soon it's done it will upload it and you can autorestic upgrade
Also of course pass the --ci flag to the cron. :)
Let me know 😊

sumnerboy12 · 2020-11-22T20:42:36Z

Ok - the output is cleaned up but there is no mention of which backend/location is being processed. It just looks like the raw restic output I think. Any chance we can get more detailed logging of what is actually being processed? Very hard to tell in the log below what repo has been backed up etc. NOTE: this is running with --verbose.

Configuring Backends

Backing Up
Files:           0 new,     0 changed, 22690 unmodified
Dirs:            0 new,     0 changed,   605 unmodified
Added to the repo: 0 B

processed 22690 files, 86.238 GiB in 0:13
snapshot 28bfb301 saved
Files:           0 new,     0 changed, 22690 unmodified
Dirs:            0 new,     0 changed,   605 unmodified
Added to the repo: 0 B

processed 22690 files, 86.238 GiB in 0:02
snapshot a2c0c4b1 saved

Finished!  ^=^n^i

cupcakearmy · 2020-11-30T14:56:53Z

I just checked. So this happens only with the --verbose flag. I'm going to look into it and see what happens there
Withouth the --verbose and only --ci flag there is a list of what happened

sumnerboy12 · 2020-11-30T19:47:13Z

I just tested without --verbose and didn't notice any difference. Here is the output when running from the command line;

root@pve:/home/ben# /usr/bin/autorestic --config /etc/.autorestic.yml --ci backup --location nas-personal

Configuring Backends
b2-personal : Configuring... ⏳
b2-personal : Done ✓
rest-personal : Configuring... ⏳
rest-personal : Done ✓

Backing Up
nas-personal ▶ b2-personal : Backing up... ⏳
nas-personal ▶ b2-personal : Done ✓ (8s)
               rest-personal : Backing up... ⏳
               rest-personal : Done ✓ (1s)

Finished! 🎉

And then exactly the same command, but piping to a log file results in;

root@pve:/home/ben# /usr/bin/autorestic --config /etc/.autorestic.yml --ci backup --location nas-personal >> test.log
root@pve:/home/ben# cat test.log

Configuring Backends

Backing Up

Finished! 🎉

sumnerboy12 · 2021-02-07T20:35:08Z

@cupcakearmy sorry to keep bugging you but is this still on your radar? it is not a major by any stretch but it would be great to have more useful logging for reconciliation and validation. no problem if you have higher priority issues to attend to of course!

cupcakearmy · 2021-02-09T15:21:02Z

It's on the list 🙂 I'm just burried in academic stuff right now unfortunately 😒 End of March there could be light xD

sumnerboy12 · 2021-02-09T16:39:31Z

No problems! Sorry to be pushy! Best of luck with your studies.

…

On Wed, 10 Feb 2021, 04:21 Nicco, ***@***.***> wrote: It's on the list 🙂 I'm just burried in academic stuff right now unfortunately 😒 End of March there could be light xD — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#28 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGTR2ROYQVKNYV35GEB54LS6FHHBANCNFSM4PGHMYWQ> .

cupcakearmy · 2021-04-17T16:01:26Z

So.. it's been a long time. I've rewritten the whole thing in Go the past week and it's way more stable (and smaller).
@sumnerboy12 should be fixed. Feel free to repoen if that is not the case.
Note the (small) upgrade guide https://autorestic.vercel.app/upgrade

cupcakearmy self-assigned this Jul 24, 2020

cupcakearmy added this to the 1.0 milestone Jul 24, 2020

cupcakearmy added the enhancement New feature or request label Jul 24, 2020

cupcakearmy closed this as completed Nov 13, 2020

cupcakearmy reopened this Nov 16, 2020

cupcakearmy closed this as completed Apr 17, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

log file doesn't contain backend/location details #28

log file doesn't contain backend/location details #28

sumnerboy12 commented Jul 24, 2020

cupcakearmy commented Jul 24, 2020

stosem commented Aug 6, 2020

sumnerboy12 commented Oct 14, 2020

cupcakearmy commented Oct 16, 2020

cupcakearmy commented Nov 13, 2020 •

edited

Loading

cupcakearmy commented Nov 13, 2020

sumnerboy12 commented Nov 15, 2020

cupcakearmy commented Nov 15, 2020

cupcakearmy commented Nov 16, 2020

sumnerboy12 commented Nov 22, 2020 •

edited

Loading

cupcakearmy commented Nov 30, 2020 •

edited

Loading

sumnerboy12 commented Nov 30, 2020

sumnerboy12 commented Feb 7, 2021

cupcakearmy commented Feb 9, 2021

sumnerboy12 commented Feb 9, 2021 via email

cupcakearmy commented Apr 17, 2021

log file doesn't contain backend/location details #28

log file doesn't contain backend/location details #28

Comments

sumnerboy12 commented Jul 24, 2020

cupcakearmy commented Jul 24, 2020

stosem commented Aug 6, 2020

sumnerboy12 commented Oct 14, 2020

cupcakearmy commented Oct 16, 2020

cupcakearmy commented Nov 13, 2020 • edited Loading

cupcakearmy commented Nov 13, 2020

sumnerboy12 commented Nov 15, 2020

cupcakearmy commented Nov 15, 2020

cupcakearmy commented Nov 16, 2020

sumnerboy12 commented Nov 22, 2020 • edited Loading

cupcakearmy commented Nov 30, 2020 • edited Loading

sumnerboy12 commented Nov 30, 2020

sumnerboy12 commented Feb 7, 2021

cupcakearmy commented Feb 9, 2021

sumnerboy12 commented Feb 9, 2021 via email

cupcakearmy commented Apr 17, 2021

cupcakearmy commented Nov 13, 2020 •

edited

Loading

sumnerboy12 commented Nov 22, 2020 •

edited

Loading

cupcakearmy commented Nov 30, 2020 •

edited

Loading