Skip to content

Commit

Permalink
Merge pull request #8142 from asi1024/fix-test-vectorstrength
Browse files Browse the repository at this point in the history
Fix invalid `vectorstength` tests
  • Loading branch information
kmaehashi committed Jan 26, 2024
2 parents 5d5ef64 + 3e346b5 commit 149a0a9
Showing 1 changed file with 4 additions and 8 deletions.
12 changes: 4 additions & 8 deletions tests/cupyx_tests/scipy_tests/signal_tests/test_spectral.py
Original file line number Diff line number Diff line change
Expand Up @@ -1295,23 +1295,19 @@ def test_partial_2dperiod(self, xp, scp):
strength, phase = scp.signal.vectorstrength(events, period)
return strength, phase

@testing.with_requires('scipy>=1.12.0rc1')
@testing.numpy_cupy_allclose(scipy_name='scp', rtol=1e-7, atol=1e-7)
def test_opposite_1dperiod(self, xp, scp):
events = xp.array([0, .25, .5, .75])
period = 1.
strength, _ = scp.signal.vectorstrength(events, period)
return strength

strength, phase = scp.signal.vectorstrength(events, period)
return strength, phase

@testing.with_requires('scipy>=1.12.0rc1')
@testing.numpy_cupy_allclose(scipy_name='scp', rtol=1e-7, atol=1e-7)
def test_opposite_2dperiod(self, xp, scp):
events = xp.array([0, .25, .5, .75])
period = [1.] * 10

strength, phase = scp.signal.vectorstrength(events, period)
return strength, phase
strength, _ = scp.signal.vectorstrength(events, period)
return strength

@pytest.mark.parametrize('mod', [(cupy, cupyx.scipy), (np, scipy)])
def test_2d_events_ValueError(self, mod):
Expand Down

0 comments on commit 149a0a9

Please sign in to comment.