Merge pull request #8058 from asi1024/fix-dst

Fix `cupyx.scipy.fft.{dst,dstn}` in type 2/3
cupy · Jan 5, 2024 · c093300 · c093300
2 parents 60242bb + 69ee93d
commit c093300
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/cupyx/scipy/fft/_realtransforms.py b/cupyx/scipy/fft/_realtransforms.py
@@ -190,15 +190,15 @@ def _dct_or_dst_type2(
     x *= tmp  # broadcasting
     x = cupy.real(x)
 
-    if dst:
-        slrev = [slice(None)] * x.ndim
-        slrev[axis] = slice(None, None, -1)
-        x = x[tuple(slrev)]
-
     if norm == 'ortho':
         sl0 = [slice(None)] * x.ndim
         sl0[axis] = slice(1)
         x[tuple(sl0)] *= math.sqrt(2) * 0.5
+
+    if dst:
+        slrev = [slice(None)] * x.ndim
+        slrev[axis] = slice(None, None, -1)
+        x = x[tuple(slrev)]
     return x
 
 
@@ -315,6 +315,9 @@ def _dct_or_dst_type3(
     sl0[axis] = slice(1)
 
     if dst:
+        slrev = [slice(None)] * x.ndim
+        slrev[axis] = slice(None, None, -1)
+        x = x[tuple(slrev)]
         if norm == 'ortho':
             float_dtype = cupy.promote_types(x.dtype, cupy.float32)
             if x.dtype != float_dtype:
@@ -323,9 +326,6 @@ def _dct_or_dst_type3(
                 x = x.copy()
             x[tuple(sl0)] *= math.sqrt(2)
             sl0_scale = 0.5
-        slrev = [slice(None)] * x.ndim
-        slrev[axis] = slice(None, None, -1)
-        x = x[tuple(slrev)]
 
     # scale by exponentials and normalization factor
     tmp = _exp_factor_dct3(x, n, axis, dtype, norm_factor)

diff --git a/tests/cupyx_tests/scipy_tests/fft_tests/test_realtransforms.py b/tests/cupyx_tests/scipy_tests/fft_tests/test_realtransforms.py
@@ -46,7 +46,7 @@
         }
     )
 )
-@testing.with_requires('scipy>=1.4')
+@testing.with_requires('scipy>1.11')
 class TestDctDst:
 
     def _run_transform(self, dct_func, xp, dtype):
@@ -133,7 +133,7 @@ def test_dct_backend(self, xp, dtype):
         )
     )
 )
-@testing.with_requires('scipy>=1.4')
+@testing.with_requires('scipy>1.11')
 class TestDctnDstn():
 
     def _run_transform(self, dct_func, xp, dtype):