Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use bit operation when the divisor is a power of 2 on GPU #1555

Merged
merged 1 commit into from Aug 31, 2018
Merged

Use bit operation when the divisor is a power of 2 on GPU #1555

merged 1 commit into from Aug 31, 2018

Conversation

okuta
Copy link
Member

@okuta okuta commented Aug 21, 2018

/' and %` are very slow on GPU.
The new version uses bit operation when the divisor is a power of 2.

@okuta okuta added the cat:performance Performance in terms of speed or memory consumption label Aug 21, 2018
@okuta
Copy link
Member Author

okuta commented Aug 26, 2018

jenkins, test this please.

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 9202400, target branch master) succeeded!

toslunar
toslunar approved these changes Aug 31, 2018
View reviewed changes
Copy link
Member

@toslunar toslunar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toslunar toslunar self-assigned this Aug 31, 2018
@toslunar toslunar merged commit c681a2a into cupy:master Aug 31, 2018
@toslunar toslunar added this to the v5.0.0b5 milestone Aug 31, 2018
@okuta okuta deleted the fast-div-mod branch July 27, 2019 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toslunar toslunar toslunar approved these changes

Assignees

@toslunar toslunar

Labels
cat:performance Performance in terms of speed or memory consumption
Projects
None yet
Milestone
v5.0.0rc1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@okuta @chainer-ci @toslunar