Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance tests for type routines #2306

Merged
merged 5 commits into from Jul 17, 2019
Merged

Enhance tests for type routines #2306

merged 5 commits into from Jul 17, 2019

Conversation

asi1024
Copy link
Member

@asi1024 asi1024 commented Jul 17, 2019 •
edited

Enhanced tests for can_cast, common_type and result_type (implemented in #2249 as wrappers to NumPy functions).

@asi1024 asi1024 added the cat:test Test code / CI label Jul 17, 2019
@kmaehashi
Copy link
Member

pfnCI, test this please.

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 3af8598:

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 3af8598, target branch master) failed with status FAILURE.

@asi1024 asi1024 added the to-be-backported Pull-requests to be backported to stable branch label Jul 17, 2019
@kmaehashi
Copy link
Member

pfnCI, test this please.

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 95fd10e:

@kmaehashi kmaehashi added the st:test-and-merge (deprecated) Ready to merge after test pass. label Jul 17, 2019
kmaehashi
kmaehashi approved these changes Jul 17, 2019
View reviewed changes
Copy link
Member

@kmaehashi kmaehashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@asi1024
Copy link
Member Author

asi1024 commented Jul 17, 2019

pfnCI, test this please.

@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 2658896:

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 2658896, target branch master) succeeded!

@kmaehashi kmaehashi merged commit 18c7d90 into cupy:master Jul 17, 2019
@kmaehashi kmaehashi mentioned this pull request Jul 17, 2019
Merged
kmaehashi added a commit to kmaehashi/cupy that referenced this pull request Jul 17, 2019
@kmaehashi
Merge pull request cupy#2306 from asi1024/type-routines-test
7da6c43 
Enhanced tests for type routines
@asi1024 asi1024 deleted the type-routines-test branch July 17, 2019 09:17
@kmaehashi kmaehashi added this to the v7.0.0b2 milestone Jul 18, 2019
@kmaehashi kmaehashi changed the title Enhanced tests for type routines Enhance tests for type routines Jul 18, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 2658896, target branch master) failed with status FAILURE.

@asi1024 asi1024 mentioned this pull request Aug 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmaehashi kmaehashi kmaehashi approved these changes

Assignees

@kmaehashi kmaehashi

Labels
cat:test Test code / CI st:test-and-merge (deprecated) Ready to merge after test pass. to-be-backported Pull-requests to be backported to stable branch
Projects
None yet
Milestone
v7.0.0b2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@asi1024 @kmaehashi @pfn-ci-bot @chainer-ci