Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport] Add take_along_axis #2346

Closed
wants to merge 1 commit into from
Closed

[backport] Add take_along_axis #2346

wants to merge 1 commit into from

Conversation

takagi
Copy link
Member

@takagi takagi commented Jul 30, 2019

Backport of #2314

@takagi
Copy link
Member Author

takagi commented Jul 30, 2019

[automatic post] Jenkins, test this please.

@takagi takagi added backport Pull-requests backported from development branch cat:feature New features/APIs labels Jul 30, 2019
@pfn-ci-bot
Copy link
Collaborator

Successfully created a job for commit 72b499e:

@takagi
Copy link
Member Author

takagi commented Jul 30, 2019

Just I missed making this backport when I merged the original one.

@asi1024
Copy link
Member

asi1024 commented Jul 30, 2019

Should PR #2314 be backported? #2314 only adds a new feature and does not fix any bug.

@chainer-ci
Copy link
Member

Jenkins CI test (for commit 72b499e, target branch v6) failed with status FAILURE.

@takagi
Copy link
Member Author

takagi commented Jul 30, 2019

I'm a bit confused if features should be backported or not by this comment

As you say, features are basically not backported:

Let me close this PR.

@takagi takagi closed this Jul 30, 2019
@takagi takagi deleted the bp-2314-take_along_axis branch July 30, 2019 06:41
@kmaehashi kmaehashi added this to the Closed issues and PRs milestone Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@asi1024 asi1024

Labels
backport Pull-requests backported from development branch cat:feature New features/APIs
Projects
None yet
Milestone
Closed PRs
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@takagi @pfn-ci-bot @asi1024 @chainer-ci @kmaehashi