Remove random.power test with forbidden value
#2375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niboshi
added
cat:test
asi1024
reviewed
Aug 8, 2019
| @@ -539,7 +539,7 @@ def test_power(self, a_dtype, dtype): | |||
| @cupy.testing.for_float_dtypes('dtype', no_float16=True) | |||
| @cupy.testing.for_float_dtypes('a_dtype') | |||
| def test_power_for_zero_a(self, a_dtype, dtype): | |||
There was a problem hiding this comment.
Why not rename this test?
Suggested change
| def test_power_for_zero_a(self, a_dtype, dtype): | |
| def test_power_for_one_a(self, a_dtype, dtype): |
There was a problem hiding this comment.
Oh I have no idea. Maybe we can just remove this test?
niboshi
force-pushed
the
fix-test-distr-power
branch
from
c45a3dd
to
ef81bc9
Compare
niboshi
changed the title
random.power test with forbidden value
|
Removed the test. PTAL |
|
LGTM. pfnCI, test this please. |
|
Successfully created a job for commit ef81bc9: |
asi1024
approved these changes
Aug 8, 2019
|
Jenkins CI test (for commit ef81bc9, target branch master) failed with status FAILURE. |
|
pfnCI, test this please. |
|
Successfully created a job for commit ef81bc9: |
|
Jenkins CI test (for commit ef81bc9, target branch master) failed with status FAILURE. |
|
LGTM. |
asi1024
added a commit
to asi1024/cupy
that referenced
this pull request
Aug 8, 2019
Remove `random.power` test with forbidden value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of #2370
a=0has been forbidden innumpy.random.power, but it seems it only became an error in NumPy 1.17.