Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed not to import cupyx.fallback_mode default when importing cupyx #2540

Merged
merged 1 commit into from Oct 11, 2019
Merged

Fixed not to import cupyx.fallback_mode default when importing cupyx #2540

merged 1 commit into from Oct 11, 2019

Conversation

asi1024
Copy link
Member

@asi1024 asi1024 commented Oct 10, 2019

Some initialization processes are triggered when importing cupy.fallback_mode, but these processes are not needed if fallback mode is not used.

@asi1024 asi1024 mentioned this pull request Oct 10, 2019
Merged
@niboshi
Copy link
Member

niboshi commented Oct 11, 2019

I couldn't see any noticeable difference on how long import cupyx takes.

@niboshi
Copy link
Member

niboshi commented Oct 11, 2019

I think the motivation of this PR is more apparent in #2541.
I'll merge #2541 along with this fix.

@niboshi niboshi merged commit a992c33 into cupy:master Oct 11, 2019
@niboshi
Copy link
Member

niboshi commented Oct 11, 2019

Merged in #2541

@niboshi niboshi added this to the Closed issues and PRs milestone Oct 11, 2019
@asi1024 asi1024 deleted the import-fallback_mode branch October 11, 2019 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@niboshi niboshi

Labels
None yet
Projects
None yet
Milestone
Closed PRs
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asi1024 @niboshi